Thread (7 messages) 7 messages, 6 authors, 2022-01-04

Re: [PATCH bpf-next v2] net: don't include filter.h from net/sock.h

From: Florian Fainelli <f.fainelli@gmail.com>
Date: 2021-12-29 01:33:52
Also in: ath11k, bpf, bridge, intel-wired-lan, linux-bluetooth, linux-can, linux-fsdevel, linux-hams, linux-nfs, linux-rdma, linux-s390, linux-wireless, netfilter-devel, virtualization


On 12/28/2021 4:49 PM, Jakub Kicinski wrote:
sock.h is pretty heavily used (5k objects rebuilt on x86 after
it's touched). We can drop the include of filter.h from it and
add a forward declaration of struct sk_filter instead.
This decreases the number of rebuilt objects when bpf.h
is touched from ~5k to ~1k.

There's a lot of missing includes this was masking. Primarily
in networking tho, this time.

Acked-by: Marc Kleine-Budde <mkl@pengutronix.de>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>

It would be nice if we used the number of files rebuilt because of a 
header file change as another metric that the kernel is evaluated with 
from release to release (or even on a commit by commit basis). Food for 
thought.
-- 
Florian
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help