Thread (8 messages) 8 messages, 3 authors, 2021-12-29

Re: [PATCH] net: check passed optlen before reading

flat view

From: Tamir Duberstein <hidden>
Date: 2021-12-29 19:47:04
Also in: lkml

I'm having some trouble sending this using git send-email because of
the firewall I'm behind.

Please pull from
  git://github.com/tamird/linux raw-check-optlen
to get these changes:
  280c5742aab2 ipv6: raw: check passed optlen before reading

If this is not acceptable, I'll send the patch again when I'm outside
the firewall. Apologies.

On Wed, Dec 29, 2021 at 10:09 AM Willem de Bruijn
[off-list ref] wrote:
On Tue, Dec 28, 2021 at 6:54 PM Jakub Kicinski [off-list ref] wrote:
quoted
On Tue, 28 Dec 2021 16:02:29 -0500 Tamir Duberstein wrote:
quoted
Errant brace in the earlier version.

From 8586be4d72c6c583b1085d2239076987e1b7c43a Mon Sep 17 00:00:00 2001
From: Tamir Duberstein <redacted>
Date: Tue, 28 Dec 2021 15:09:11 -0500
Subject: [PATCH v2] net: check passed optlen before reading

Add a check that the user-provided option is at least as long as the
number of bytes we intend to read. Before this patch we would blindly
read sizeof(int) bytes even in cases where the user passed
optlen<sizeof(int), which would potentially read garbage or fault.

Discovered by new tests in https://github.com/google/gvisor/pull/6957 .

Signed-off-by: Tamir Duberstein <redacted>
Your patches are corrupted by your email client.

Can you try sending the latest version with git send-email?
Then perhaps also update the subject line to make it more clear where
this applies: "ipv6: raw: check passed optlen before reading".
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help