Re: [PATCH] asix: Use min() instead of doing it manually
flat view
From: Heiner Kallweit <hkallweit1@gmail.com>
Date: 2021-12-26 17:18:53
Also in:
linux-usb, lkml
On 25.12.2021 18:08, Jiapeng Chong wrote:
quoted hunk ↗ jump to hunk
Fix following coccicheck warning: ./drivers/net/usb/asix_common.c:545:12-13: WARNING opportunity for min(). Reported-by: Abaci Robot <redacted> Signed-off-by: Jiapeng Chong <redacted> --- drivers/net/usb/asix_common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/drivers/net/usb/asix_common.c b/drivers/net/usb/asix_common.c index 71682970be58..da5a7df312d2 100644 --- a/drivers/net/usb/asix_common.c +++ b/drivers/net/usb/asix_common.c@@ -542,7 +542,7 @@ static int __asix_mdio_write(struct net_device *netdev, int phy_id, int loc, out: mutex_unlock(&dev->phy_mutex); - return ret < 0 ? ret : 0; + return min(ret, 0);
Same comment as for a previous such patch. It doesn't make sense. Also coccicheck isn't always right, please check whether a warning is justified before sending a "fix".
} void asix_mdio_write(struct net_device *netdev, int phy_id, int loc, int val)