Thread (2 messages) 2 messages, 2 authors, 2021-12-24

RE: [PATCH] rtw88: add quirk to disable pci caps on HP Slim Desktop S01-pF1000i

From: Pkshih <pkshih@realtek.com>
Date: 2021-12-24 07:03:44
Also in: linux-wireless, lkml

quoted hunk ↗ jump to hunk
-----Original Message-----
From: Yu-Tung Chang <redacted>
Sent: Friday, December 24, 2021 2:49 PM
To: tony0620emma@gmail.com
Cc: kvalo@kernel.org; davem@davemloft.net; kuba@kernel.org; linux-wireless@vger.kernel.org;
netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Yu-Tung Chang [off-list ref]
Subject: [PATCH] rtw88: add quirk to disable pci caps on HP Slim Desktop S01-pF1000i

8821CE causes random freezes on HP Slim Desktop S01-pF1000i. Add a quirk
to disable pci ASPM capability.

Signed-off-by: Yu-Tung Chang <redacted>
---
 drivers/net/wireless/realtek/rtw88/pci.c | 9 +++++++++
 1 file changed, 9 insertions(+)
diff --git a/drivers/net/wireless/realtek/rtw88/pci.c b/drivers/net/wireless/realtek/rtw88/pci.c
index a7a6ebfaa203..f8999d7dee61 100644
--- a/drivers/net/wireless/realtek/rtw88/pci.c
+++ b/drivers/net/wireless/realtek/rtw88/pci.c
@@ -1738,6 +1738,15 @@ static const struct dmi_system_id rtw88_pci_quirks[] = {
 		},
 		.driver_data = (void *)BIT(QUIRK_DIS_PCI_CAP_ASPM),
 	},
+	{
+		.callback = disable_pci_caps,
+		.ident = "HP HP Slim Desktop S01-pF1xxx",
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "HP"),
+			DMI_MATCH(DMI_PRODUCT_NAME, "HP Slim Desktop S01-pF1xxx"),
+		},
+		.driver_data = (void *)BIT(QUIRK_DIS_PCI_CAP_ASPM),
+	},
 	{}
 };
A patch [1] is merged to fix freezes of 8821ce.

[1] https://lore.kernel.org/all/20211215114635.333767-1-kai.heng.feng@canonical.com/ (local)

--
Ping-Ke
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help