Re: [PATCH v5] fjes: Check for error irq
flat view
From: Jakub Kicinski <kuba@kernel.org>
Date: 2021-12-24 03:14:21
Also in:
lkml
On Fri, 24 Dec 2021 09:34:45 +0800 Jiasheng Jiang wrote:
The platform_get_irq() is possible to fail.
And the returned irq could be error number and will finally cause the
failure of the request_irq().
Consider that platform_get_irq() can now in certain cases return
-EPROBE_DEFER, and the consequences of letting request_irq() effectively
convert that into -EINVAL, even at probe time rather than later on.
So it might be better to check just now.
Fixes: 658d439b2292 ("fjes: Introduce FUJITSU Extended Socket Network Device driver")
Signed-off-by: Jiasheng Jiang <redacted>Please take note of the notifications you're getting. The previous versions of this and the other two patches you posted shortly after were already merged into the net tree: https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git/commit/?id=db6d6afe382de5a65d6ccf51253ab48b8e8336c3 If you want to refactor the check you need to send an incremental change (IOW diff against the previously applied patch).