Re: [PATCH] net: ethernet: mellanox: return errno instead of 1
flat view
From: Saeed Mahameed <hidden>
Date: 2021-12-23 19:35:01
Also in:
linux-rdma, lkml
On Wed, 2021-12-22 at 18:24 -0800, Qing Wang wrote:
quoted hunk ↗ jump to hunk
From: Wang Qing <redacted> mlx5e_hv_vhca_stats_create() better return specific error than 1 Signed-off-by: Wang Qing <redacted> --- drivers/net/ethernet/mellanox/mlx5/core/en/hv_vhca_stats.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en/hv_vhca_stats.c b/drivers/net/ethernet/mellanox/mlx5/core/en/hv_vhca_stats.c index d290d72..04cda3d--- a/drivers/net/ethernet/mellanox/mlx5/core/en/hv_vhca_stats.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/en/hv_vhca_stats.c@@ -142,7 +142,7 @@ int mlx5e_hv_vhca_stats_create(struct mlx5e_priv*priv) PTR_ERR(agent)); kvfree(priv->stats_agent.buf); - return IS_ERR_OR_NULL(agent); + return agent ? PTR_ERR(agent) : -ENODEV;
the single caller of this function ignores the return value, I just made a patch to void the return value and added you as Reported- by. Thanks !