Thread (6 messages) 6 messages, 3 authors, 2021-12-23

Re: [PATCH v1 1/1] wwan: Replace kernel.h with the necessary inclusions

From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Date: 2021-12-23 10:18:24
Also in: lkml

On Thu, Dec 23, 2021 at 12:14:09PM +0200, Andy Shevchenko wrote:
On Wed, Dec 22, 2021 at 11:38:44PM +0300, Sergey Ryazanov wrote:
quoted
On Wed, Dec 22, 2021 at 7:32 PM Andy Shevchenko
[off-list ref] wrote:
...
Not sure what it's supposed from me to do. The forward declarations are
the tighten part of the cleanup (*) and it's exactly what is happening here,
i.e.  replacing kernel.h "with the list of what is really being used".

*) Either you need a header, or you need a forward declaration, or rely on
   the compiler not to be so strict. I prefer the second option out of three.
Ah, seems indeed the skbuf and netdevice ones can be split. Do you want me to
resend as series of two?

(Sorry I have sent many similar changes and haven't remembered by heart where
 I did what exactly, but here it looks natural to cleanup that stuff at the
 same time, so the question is if it should be a separate change or not)

-- 
With Best Regards,
Andy Shevchenko

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help