Re: [PATCH v2 2/2] asix: fix wrong return value in asix_check_host_enable()
flat view
From: Andrew Lunn <andrew@lunn.ch>
Date: 2021-12-21 20:12:00
Also in:
linux-usb, lkml
On Tue, Dec 21, 2021 at 11:10:43PM +0300, Pavel Skripkin wrote:
If asix_read_cmd() returns 0 on 30th interation, 0 will be returned from
asix_check_host_enable(), which is logically wrong. Fix it by returning
-ETIMEDOUT explicitly if we have exceeded 30 iterations
Also, replaced 30 with #define as suggested by Andrew
Fixes: a786e3195d6a ("net: asix: fix uninit value bugs")
Reported-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: Pavel Skripkin <redacted>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew