Re: [PATCH net-next 0/6] prestera: add basic router driver support

On Sat, Dec 18, 2021 at 05:52:55PM +0100, Andrew Lunn wrote:

On Fri, Dec 17, 2021 at 09:54:32PM +0200, Yevhen Orlov wrote:

quoted

Add initial router support for Marvell Prestera driver.
Subscribe on inetaddr notifications. TRAP packets, that has to be routed
(if packet has router's destination MAC address).

I must be missing something here. Why do you need to tell it the IP
address in order to perform software routing? All the switch needs to
know is the MAC address. Any packets for that MAC address should be
trapped to the host. The host can then decide what to do with it,
router, bridge, or consume it itself.

You are right. We don't pass IP address. Subscription is only needed
to enable rif. IP address is not used here.

quoted

Add features:
 - Support ip address adding on port.
   e.g.: "ip address add PORT 1.1.1.1/24"

This should just work already. If it does not, you have something
wrong in your current support.

	Andrew

Yes. For now we has just enabled TRAP's for every port. This is good for
software routing. But in order to implement routes offloading - we need
to control, on which port packets is routed. So, this patchset
prepares infrastructure for future routes offloading implementation.