Re: [PATCH v6, 2/2] net: Add dm9051 driver
From: Jakub Kicinski <kuba@kernel.org>
Date: 2021-12-16 15:17:49
Also in:
linux-devicetree, lkml
On Thu, 16 Dec 2021 17:32:46 +0800 Joseph CHAMG wrote:
Add davicom dm9051 spi ethernet driver, The driver work with the device platform's spi master remove the redundant code that phylib has support, adjust to be the reasonable sequence, fine tune comments, add comments for pause function support Tested with raspberry pi 4. Test for netwroking function, CAT5 cable unplug/plug and also ethtool detect for link state, and all are ok.
Please install sparse and make sure the driver builds cleanly with W=1 C=1 flags. drivers/net/ethernet/davicom/dm9051.c:349:26: warning: symbol 'dm9051_ethtool_ops' was not declared. Should it be static? drivers/net/ethernet/davicom/dm9051.c:381:31: warning: incorrect type in initializer (different base types) drivers/net/ethernet/davicom/dm9051.c:381:31: expected int rxlen drivers/net/ethernet/davicom/dm9051.c:381:31: got restricted __le16 [usertype] rxlen drivers/net/ethernet/davicom/dm9051.c:421:31: warning: restricted __le16 degrades to integer drivers/net/ethernet/davicom/dm9051.c:426:23: warning: incorrect type in assignment (different base types) drivers/net/ethernet/davicom/dm9051.c:426:23: expected int rxlen drivers/net/ethernet/davicom/dm9051.c:426:23: got restricted __le16 [usertype] rxlen