Re: [PATCH net-next 3/3] net: fec: reset phy on resume after power-up

On Thu, Dec 16, 2021 at 12:28:19PM +0100, Andrew Lunn wrote:

On Thu, Dec 16, 2021 at 12:24:33PM +0100, Francesco Dolcini wrote:

quoted

On Thu, Dec 16, 2021 at 11:24:24AM +0100, Andrew Lunn wrote:

quoted

I think you need to move the regulator into phylib, so the PHY driver
can do the right thing. It is really the only entity which knows what
is the correct thing to do.

quoted

Do you believe that the right place is the phylib and not the phy driver?
Is this generic enough?

It is split. phylib can do the lookup in DT, get the regulator and
provide a helper to enable/disable it. So very similar to the reset.

Sounds good.

Can we safely assume that we do have at most one regulator for the phy?

Francesco