[PATCH] scsi: qedf: potential dereference of null pointer

Subsystems: qlogic ql41xxx fcoe driver, scsi subsystem, the rest

STALE1738d LANDED

Landed in mainline as aa7069d840da on 2022-01-05.

5 messages, 4 authors, 2022-01-10 · open the first message on its own page

[PATCH] scsi: qedf: potential dereference of null pointer

From: Jiasheng Jiang <hidden>
Date: 2021-12-16 10:15:18

The return value of dma_alloc_coherent() needs to be checked.
To avoid use of null pointer in case of the failure of alloc.

Fixes: 61d8658b4a43 ("scsi: qedf: Add QLogic FastLinQ offload FCoE driver framework.")
Signed-off-by: Jiasheng Jiang <redacted>
---
 drivers/scsi/qedf/qedf_main.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/scsi/qedf/qedf_main.c b/drivers/scsi/qedf/qedf_main.c
index b92570a7c309..309e205a8e70 100644
--- a/drivers/scsi/qedf/qedf_main.c
+++ b/drivers/scsi/qedf/qedf_main.c

@@ -1415,6 +1415,8 @@ static void qedf_upload_connection(struct qedf_ctx *qedf,
 	 */
 	term_params = dma_alloc_coherent(&qedf->pdev->dev, QEDF_TERM_BUFF_SIZE,
 		&term_params_dma, GFP_KERNEL);
+	if (!term_params)
+		return;
 
 	QEDF_INFO(&(qedf->dbg_ctx), QEDF_LOG_CONN, "Uploading connection "
 		   "port_id=%06x.\n", fcport->rdata->ids.port_id);

-- 
2.25.1

RE: [EXT] [PATCH] scsi: qedf: potential dereference of null pointer

From: Saurav Kashyap <skashyap@marvell.com>
Date: 2022-01-03 04:59:33

Hi Jiasheng Jiang,

quoted hunk

-----Original Message-----
From: Jiasheng Jiang <redacted>
Sent: Thursday, December 16, 2021 3:45 PM
To: Saurav Kashyap <skashyap@marvell.com>; Javed Hasan
[off-list ref]; GR-QLogic-Storage-Upstream <GR-QLogic-Storage-
Upstream@marvell.com>; jejb@linux.ibm.com; martin.petersen@oracle.com;
linux@armlinux.org.uk
Cc: linux-scsi@vger.kernel.org; linux-kernel@vger.kernel.org;
netdev@vger.kernel.org; Jiasheng Jiang [off-list ref]
Subject: [EXT] [PATCH] scsi: qedf: potential dereference of null pointer

External Email

----------------------------------------------------------------------
The return value of dma_alloc_coherent() needs to be checked.
To avoid use of null pointer in case of the failure of alloc.

Fixes: 61d8658b4a43 ("scsi: qedf: Add QLogic FastLinQ offload FCoE driver
framework.")
Signed-off-by: Jiasheng Jiang <redacted>
---
 drivers/scsi/qedf/qedf_main.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/scsi/qedf/qedf_main.c b/drivers/scsi/qedf/qedf_main.c
index b92570a7c309..309e205a8e70 100644
--- a/drivers/scsi/qedf/qedf_main.c
+++ b/drivers/scsi/qedf/qedf_main.c

@@ -1415,6 +1415,8 @@ static void qedf_upload_connection(struct qedf_ctx

*qedf,
 	 */
 	term_params = dma_alloc_coherent(&qedf->pdev->dev,
QEDF_TERM_BUFF_SIZE,
 		&term_params_dma, GFP_KERNEL);
+	if (!term_params)
+		return;

<SK> Adding message about failure before returning will help in debugging.

Thanks,
~Saurav

 	QEDF_INFO(&(qedf->dbg_ctx), QEDF_LOG_CONN, "Uploading
connection "
 		   "port_id=%06x.\n", fcport->rdata->ids.port_id);
--
2.25.1

Re: [EXT] [PATCH] scsi: qedf: potential dereference of null pointer

From: Jakub Kicinski <kuba@kernel.org>
Date: 2022-01-03 17:12:27

On Mon, 3 Jan 2022 04:58:41 +0000 Saurav Kashyap wrote:

quoted

QEDF_TERM_BUFF_SIZE,
 		&term_params_dma, GFP_KERNEL);
+	if (!term_params)
+		return;

<SK> Adding message about failure before returning will help in debugging.

Memory allocations produce a pretty detailed splat.

RE: [EXT] [PATCH] scsi: qedf: potential dereference of null pointer

From: Saurav Kashyap <skashyap@marvell.com>
Date: 2022-01-04 04:05:59

HI Jiasheng Jiang,

quoted hunk

-----Original Message-----
From: Jiasheng Jiang <redacted>
Sent: Thursday, December 16, 2021 3:45 PM
To: Saurav Kashyap <skashyap@marvell.com>; Javed Hasan
[off-list ref]; GR-QLogic-Storage-Upstream <GR-QLogic-Storage-
Upstream@marvell.com>; jejb@linux.ibm.com; martin.petersen@oracle.com;
linux@armlinux.org.uk
Cc: linux-scsi@vger.kernel.org; linux-kernel@vger.kernel.org;
netdev@vger.kernel.org; Jiasheng Jiang [off-list ref]
Subject: [EXT] [PATCH] scsi: qedf: potential dereference of null pointer

External Email

----------------------------------------------------------------------
The return value of dma_alloc_coherent() needs to be checked.
To avoid use of null pointer in case of the failure of alloc.

Fixes: 61d8658b4a43 ("scsi: qedf: Add QLogic FastLinQ offload FCoE driver
framework.")
Signed-off-by: Jiasheng Jiang <redacted>
---
 drivers/scsi/qedf/qedf_main.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/scsi/qedf/qedf_main.c b/drivers/scsi/qedf/qedf_main.c
index b92570a7c309..309e205a8e70 100644
--- a/drivers/scsi/qedf/qedf_main.c
+++ b/drivers/scsi/qedf/qedf_main.c

@@ -1415,6 +1415,8 @@ static void qedf_upload_connection(struct qedf_ctx

*qedf,
 	 */
 	term_params = dma_alloc_coherent(&qedf->pdev->dev,
QEDF_TERM_BUFF_SIZE,
 		&term_params_dma, GFP_KERNEL);
+	if (!term_params)
+		return;

 	QEDF_INFO(&(qedf->dbg_ctx), QEDF_LOG_CONN, "Uploading
connection "
 		   "port_id=%06x.\n", fcport->rdata->ids.port_id);
--

Acked-by: Saurav Kashyap <skashyap@marvell.com>

Thanks,
~Saurav

2.25.1

Re: [PATCH] scsi: qedf: potential dereference of null pointer

From: Martin K. Petersen <hidden>
Date: 2022-01-10 22:05:43

On Thu, 16 Dec 2021 18:14:49 +0800, Jiasheng Jiang wrote:

The return value of dma_alloc_coherent() needs to be checked.
To avoid use of null pointer in case of the failure of alloc.

Applied to 5.17/scsi-queue, thanks!

[1/1] scsi: qedf: potential dereference of null pointer
      https://git.kernel.org/mkp/scsi/c/aa7069d840da

-- 
Martin K. Petersen	Oracle Linux Engineering

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help