Thread (11 messages) flat view 11 messages, 1 author, 2021-12-16
STALE1708d LANDED: 23 (21M)

3 review trailers (1 from subsystem maintainers); landed in mainline as f77097ec8c01 on 2021-12-17.

[PATCH 02/10] bus: mhi: pci_generic: Graceful shutdown on freeze

From: Manivannan Sadhasivam <hidden>
Date: 2021-12-16 08:13:02
Also in: linux-arm-msm, lkml, stable
Subsystem: mhi bus, the rest · Maintainers: Manivannan Sadhasivam, Linus Torvalds

From: Loic Poulain <redacted>

There is no reason for shutting down MHI ungracefully on freeze,
this causes the MHI host stack & device stack to not be aligned
anymore since the proper MHI reset sequence is not performed for
ungraceful shutdown.

Fixes: 5f0c2ee1fe8d ("bus: mhi: pci-generic: Fix hibernation")
Suggested-by: Bhaumik Bhatt <redacted>
Signed-off-by: Loic Poulain <redacted>
Reviewed-by: Bhaumik Bhatt <redacted>
Reviewed-by: Hemant Kumar <redacted>
Reviewed-by: Manivannan Sadhasivam <mani@kernel.org>
Cc: stable@vger.kernel.org
Link: https://lore.kernel.org/r/1635268180-13699-1-git-send-email-loic.poulain@linaro.org (local)
Signed-off-by: Manivannan Sadhasivam <redacted>
---
 drivers/bus/mhi/pci_generic.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/bus/mhi/pci_generic.c b/drivers/bus/mhi/pci_generic.c
index 94d8aa9c2eae..4f72bbcc53c9 100644
--- a/drivers/bus/mhi/pci_generic.c
+++ b/drivers/bus/mhi/pci_generic.c
@@ -1021,7 +1021,7 @@ static int __maybe_unused mhi_pci_freeze(struct device *dev)
 	 * context.
 	 */
 	if (test_and_clear_bit(MHI_PCI_DEV_STARTED, &mhi_pdev->status)) {
-		mhi_power_down(mhi_cntrl, false);
+		mhi_power_down(mhi_cntrl, true);
 		mhi_unprepare_after_power_down(mhi_cntrl);
 	}
 
-- 
2.25.1
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help