Re: [PATCH v2 6/7] audit: Use task_is_in_init_pid_ns()

From
Paul Moore <paul@paul-moore.com>
Date
2021-12-14 22:35:28
Also in
linux-arm-kernel, lkml
Reply to
Leo Yan, 2021-12-08
On Wed, Dec 8, 2021 at 3:33 AM Leo Yan [off-list ref] wrote:
Replace open code with task_is_in_init_pid_ns() for checking root PID
namespace.

Signed-off-by: Leo Yan <redacted>
---
 kernel/audit.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
I'm not sure how necessary this is, but it looks correct to me.

Acked-by: Paul Moore <paul@paul-moore.com>
quoted hunk ↗ jump to hunk
diff --git a/kernel/audit.c b/kernel/audit.c
index 121d37e700a6..56ea91014180 100644
--- a/kernel/audit.c
+++ b/kernel/audit.c
@@ -1034,7 +1034,7 @@ static int audit_netlink_ok(struct sk_buff *skb, u16 msg_type)
        case AUDIT_MAKE_EQUIV:
                /* Only support auditd and auditctl in initial pid namespace
                 * for now. */
-               if (task_active_pid_ns(current) != &init_pid_ns)
+               if (!task_is_in_init_pid_ns(current))
                        return -EPERM;

                if (!netlink_capable(skb, CAP_AUDIT_CONTROL))
--
2.25.1
-- 
paul moore
www.paul-moore.com
Thread (24 messages) 24 messages, 6 authors, last reply 2022-01-24
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help