Re: [PATCH net] rds: memory leak in __rds_conn_create()
From: Sharath Srinivasan <hidden>
Date: 2021-12-14 11:10:01
Also in:
linux-rdma, lkml
On 12/14/21 02:46, Hangyu Hua wrote:
__rds_conn_create() did not release conn->c_path when loop_trans != 0 and trans->t_prefer_loopback != 0 and is_outgoing == 0.
Probably a good idea to include:
Fixes: aced3ce57cd3 ("RDS tcp loopback connection can hang")
Signed-off-by: Hangyu Hua <redacted>
With that, Reviewed-by: Sharath Srinivasan <redacted> Thanks, Sharath
quoted hunk ↗ jump to hunk
--- net/rds/connection.c | 1 + 1 file changed, 1 insertion(+)diff --git a/net/rds/connection.c b/net/rds/connection.c index a3bc4b54d491..b4cc699c5fad 100644 --- a/net/rds/connection.c +++ b/net/rds/connection.c@@ -253,6 +253,7 @@ static struct rds_connection *__rds_conn_create(struct net *net, * should end up here, but if it * does, reset/destroy the connection. */ + kfree(conn->c_path); kmem_cache_free(rds_conn_slab, conn); conn = ERR_PTR(-EOPNOTSUPP); goto out;