Re: [PATCH net-next v4 1/2] devicetree: bindings: net: Add bindings doc for Sunplus SP7021.

Hi Rob,

Thank you very much for your review.
Please see my replies below:

Add bindings documentation for Sunplus SP7021.

[...]

quoted

+
+  interrupts:
+    description: |
+      Contains number and type of interrupt. Number should be 66.

Drop. That's every 'interrupts' and the exact number is outside the
scope of the binding.

Yes, I'll drop the descriptions next patch.
interrupts property will be:

  interrupts:
    maxItems: 1


[...]

quoted

+
+  mdio:

Just need:

       $ref: mdio.yaml#
       unevaluatedProperties: false

and drop the rest.

Yes, I'll modify mdio node next patch.
mdio node will be:

  mdio:
    $ref: mdio.yaml#
    unevaluatedProperties: false

quoted

+    type: object
+    description: external MDIO Bus
+
+    properties:
+      "#address-cells":
+        const: 1
+
+      "#size-cells":
+        const: 0
+
+    patternProperties:
+      "^ethernet-phy@[0-9a-f]+$":
+        type: object
+        description: external PHY node
+
+        properties:
+          reg:
+            minimum: 0
+            maximum: 30

Can I limit value of 'reg' to no more than 30?

quoted

+
+        required:
+          - reg
+
+additionalProperties: false
+

[...]

quoted

+examples:
+  - |
+    #include <dt-bindings/interrupt-controller/irq.h>
+    emac: emac@9c108000 {

ethernet@9c108000 {

I'll modify it next patch.


[...]

quoted

2.7.4

Best regards,
Wells