RE: [EXT] Re: [PATCH net-next] net: stmmac: bump tc when get underflow error from DMA descriptor

Hi Jakub,

On Fri, 10 Dec 2021 10:41:00 +0800 Jakub Kicinski wrote:

quoted

quoted

net: stmmac: bump tc when get underflow error from DMA descriptor

In DMA threshold mode, frame underflow errors may sometimes occur
when the TC(threshold control) value is not enough. The TC value
need to be bumped up in this case.

There is no underflow interrupt bit on DMA_CH(#i)_Status of dwmac4,
so the DMA threshold cannot be bumped up in stmmac_dma_interrupt().
The i.mx8mp board observed an underflow error while running NFS
boot, the NFS rootfs could not be mounted.

The underflow error can be got from the DMA descriptor TDES3 on

dwmac4.

quoted

quoted

This patch bump up tc value once underflow error is got from TDES3.

Signed-off-by: Xiaoliang Yang <redacted>

5 queues with FIFO cut-through mode can work well after applying this

patch.

This never worked, correct? It's not a regression fix?

Yes, it's never worked when the underflow error is observed in the case of NFS boot on i.mx8mp. I'm not sure if other SoC have same issue in this case, but I think it's necessary to increase the threshold value in case of underflow error.
Do you mean that I need to send the patch as a bug fix to net branch?

Regards,
Xiaoliang