[PATCH] net: gro: use IS_ERR before PTR_ERR
flat view
STALE1771d
From: Guo Zhengkui <hidden>
Date: 2021-12-07 07:31:38
Also in:
lkml
Subsystem:
networking [general], the rest · Maintainers:
"David S. Miller", Eric Dumazet, Jakub Kicinski, Paolo Abeni, Linus Torvalds
fix following cocci warning: ./net/core/gro.c:493:5-12: ERROR: PTR_ERR applied after initialization to constant on line 441 Signed-off-by: Guo Zhengkui <redacted> --- net/core/gro.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/net/core/gro.c b/net/core/gro.c
index 8ec8b44596da..ee08f7b23793 100644
--- a/net/core/gro.c
+++ b/net/core/gro.c@@ -490,9 +490,11 @@ static enum gro_result dev_gro_receive(struct napi_struct *napi, struct sk_buff if (&ptype->list == head) goto normal; - if (PTR_ERR(pp) == -EINPROGRESS) { - ret = GRO_CONSUMED; - goto ok; + if (IS_ERR(pp)) { + if (PTR_ERR(pp) == -EINPROGRESS) { + ret = GRO_CONSUMED; + goto ok; + } } same_flow = NAPI_GRO_CB(skb)->same_flow;
--
2.20.1