Re: [PATCH v3 net 1/1] net: mvpp2: fix XDP rx queues registering

Hello,

On 06/12/2021 21:55, Jakub Kicinski wrote:

On Mon,  6 Dec 2021 18:22:19 +0100 Louis Amas wrote:

quoted

The registration of XDP queue information is incorrect because the
RX queue id we use is invalid. When port->id == 0 it appears to works
as expected yet it's no longer the case when port->id != 0.

The problem arised while using a recent kernel version on the
MACCHIATOBin. This board has several ports:
  * eth0 and eth1 are 10Gbps interfaces ; both ports has port->id == 0;
  * eth2 is a 1Gbps interface with port->id != 0.

Still doesn't apply to net/master [1]. Which tree is it based on?
Perhaps you are sending this for the BPF tree? [2] Hm, doesn't apply
there either...

[1] https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git/
[2] https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf.git/

Strange...

AFAIK the commit was added on top of net/master (as cloned at approximately 17:30 CET). I'll check with Louis tomorrow morning. We may have messed-up something.

-- Emmanuel Deloget