Thread (13 messages) 13 messages, 5 authors, 2021-12-14

[RFC PATCH 2/2] net: fec: reset phy in resume if it was powered down

flat view
STALE1769d

From: Philippe Schenker <hidden>
Date: 2021-12-06 10:14:04
Also in: lkml
Subsystem: freescale imx / mxc fec driver, networking drivers, the rest · Maintainers: Wei Fang, Andrew Lunn, "David S. Miller", Eric Dumazet, Jakub Kicinski, Paolo Abeni, Linus Torvalds

If a board solely rely on a GPIO to reset the PHY after power-up, the
PHY won't work after a power-down where the power was cut.

Reset the PHY after power-enable in fec_resume.

Signed-off-by: Philippe Schenker <redacted>

---

 drivers/net/ethernet/freescale/fec_main.c | 4 ++++
 1 file changed, 4 insertions(+)
diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c
index 92840f18c48f..41c3825cd768 100644
--- a/drivers/net/ethernet/freescale/fec_main.c
+++ b/drivers/net/ethernet/freescale/fec_main.c
@@ -4118,6 +4118,10 @@ static int __maybe_unused fec_resume(struct device *dev)
 		ret = regulator_enable(fep->reg_phy);
 		if (ret)
 			return ret;
+
+		ret = fec_reset_phy(ndev);
+		if (ret)
+			return ret;
 	}
 
 	rtnl_lock();
-- 
2.34.0
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help