Re: [PATCH -next] mm: delete oversized WARN_ON() in kvmalloc() calls
flat view
From: Sean Christopherson <seanjc@google.com>
Date: 2021-12-03 19:37:39
Also in:
bpf, kvm, linux-mm, lkml, netfilter-devel
+Paolo, I'm pretty sure he's still not subscribed to the KVM mailing list :-) On Wed, Dec 01, 2021, Andrew Morton wrote:
On Thu, 2 Dec 2021 12:05:15 +0800 Bixuan Cui [off-list ref] wrote:quoted
在 2021/12/2 上午11:26, Andrew Morton 写道:quoted
quoted
Delete the WARN_ON() and return NULL directly for oversized parameter in kvmalloc() calls. Also add unlikely(). Fixes: 7661809d493b ("mm: don't allow oversized kvmalloc() calls") Signed-off-by: Bixuan Cui<redacted> --- There are a lot of oversize warnings and patches about kvmalloc() calls recently. Maybe these warnings are not very necessary.Or maybe they are. Please let's take a look at these warnings, one at a time. If a large number of them are bogus then sure, let's disable the runtime test. But perhaps it's the case that calling code has genuine issues and should be repaired.Such as：Thanks, that's helpful. Let's bring all these to the attention of the relevant developers. If the consensus is "the code's fine, the warning is bogus" then let's consider retiring the warning. If the consensus is otherwise then hopefully they will fix their stuff!(cc bpf@vger.kernel.org)(cc netdev@vger.kernel.org, maintainers)(cc kvm@vger.kernel.org)
Paolo posted patches to resolve the KVM issues, but I don't think they ever got applied. https://lore.kernel.org/all/20211016064302.165220-1-pbonzini@redhat.com/ (local) https://lore.kernel.org/all/20211015165519.135670-1-pbonzini@redhat.com/ (local)