[PATCH] net/mlx5: Fix dangling pointer access
flat view
STALE1776d
From: Ameer Hamza <hidden>
Date: 2021-12-02 22:15:51
Also in:
linux-rdma, lkml
Subsystem:
mellanox mlx5 core vpi driver, networking drivers, the rest · Maintainers:
Saeed Mahameed, Leon Romanovsky, Tariq Toukan, Mark Bloch, Andrew Lunn, "David S. Miller", Eric Dumazet, Jakub Kicinski, Paolo Abeni, Linus Torvalds
Fix for dangling pointer access reported by Coverity.
Addresses-Coverity: 1494138 ("Use after free")
Signed-off-by: Ameer Hamza <redacted>
---
drivers/net/ethernet/mellanox/mlx5/core/health.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/health.c b/drivers/net/ethernet/mellanox/mlx5/core/health.c
index 3ca998874c50..856023321972 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/health.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/health.c@@ -335,7 +335,7 @@ static int mlx5_health_try_recover(struct mlx5_core_dev *dev) { mlx5_core_warn(dev, "handling bad device here\n"); mlx5_handle_bad_state(dev); - if (mlx5_health_wait_pci_up(dev)) { + if (dev->timeouts && mlx5_health_wait_pci_up(dev)) { mlx5_core_err(dev, "health recovery flow aborted, PCI reads still not working\n"); return -EIO; }
--
2.25.1