Thread (14 messages) 14 messages, 4 authors, 2021-12-03

RE: [PATCH net-next v3 1/2] devicetree: bindings: net: Add bindings doc for Sunplus SP7021.

From: Wells Lu 呂芳騰 <hidden>
Date: 2021-12-01 07:02:34
Also in: linux-devicetree, lkml

Hi Andrew,

Thank you very much for review.

I'll move properties nvmem-cells and nvmem-cell-names to ethernet ports
and change value of nvmem-cell-names to "mac-address" next patch.

I'll refer to "nvmem_get_mac_address()" when modifying code.


Best regards,
Wells

quoted
+  nvmem-cells:
+    items:
+      - description: nvmem cell address of MAC address of 1st MAC
+      - description: nvmem cell address of MAC address of 2nd MAC
+
+  nvmem-cell-names:
+    description: names corresponding to the nvmem cells of MAC address
+    items:
+      - const: mac_addr0
+      - const: mac_addr1
These are port properties, so put them in the port section.

Also, the name you should use is well defined, "mac-address".  See nvmem_get_mac_address().
But you won't be able to use that helper because it take dev, not an of node.

	Andrew
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help