Re: [PATCH net-next 1/1] qed: add prints if request_firmware() failed
flat view
From: Andrew Lunn <andrew@lunn.ch>
Date: 2021-12-26 10:26:40
On Sat, Dec 25, 2021 at 04:14:08PM -0800, Venkata Sudheer Kumar Bhavaraju wrote:
quoted hunk ↗ jump to hunk
If driver load failed due to request_firmware() not finding the device firmware file, add prints that help remedy the situation. Signed-off-by: Ariel Elior <redacted> Signed-off-by: Alok Prasad <redacted> Signed-off-by: Venkata Sudheer Kumar Bhavaraju <redacted> --- drivers/net/ethernet/qlogic/qed/qed_main.c | 6 ++++++ 1 file changed, 6 insertions(+)diff --git a/drivers/net/ethernet/qlogic/qed/qed_main.c b/drivers/net/ethernet/qlogic/qed/qed_main.c index 46d4207f22a3..4f5d5a1e786c 100644 --- a/drivers/net/ethernet/qlogic/qed/qed_main.c +++ b/drivers/net/ethernet/qlogic/qed/qed_main.c@@ -65,6 +65,9 @@ MODULE_LICENSE("GPL"); MODULE_FIRMWARE(QED_FW_FILE_NAME); +#define QED_FW_REPO \ + "https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git"
linux-firmware is vendor/product neutral. So i would suggest dropping
the QED prefix. This URL is also used in a couple of other drivers, so
you could consider places it somewhere under include/linux/
Andrew