Re: [PATCH net-next] ipv6: ioam: Support for Queue depth data field

On Dec 24, 2021, at 4:28 AM, Jakub Kicinski kuba@kernel.org wrote:

On Thu, 23 Dec 2021 16:55:15 +0100 Justin Iurman wrote:

quoted

+		} else {
+			queue = skb_get_tx_queue(skb_dst(skb)->dev, skb);
+			qdisc_qstats_qlen_backlog(queue->qdisc, &qlen, &backlog);
+
+			*(__be32 *)data = cpu_to_be32(qlen);
+		}
 		data += sizeof(__be32);
 	}
 

sparse complains that:

net/ipv6/ioam6.c:729:56: warning: incorrect type in argument 1 (different
address spaces)
net/ipv6/ioam6.c:729:56:    expected struct Qdisc *sch
net/ipv6/ioam6.c:729:56:    got struct Qdisc [noderef] __rcu *qdisc

Thanks for reporting, I indeed forgot to run sparse. I'm surprised the
bot did not report it, though. Sorry for that, will fix this in -v2.