[PATCH netfilter] netfilter: xt_owner: use sk->sk_uid for owner lookup
flat view
STALE1751d
From: Maciej Żenczykowski <hidden>
Date: 2021-12-23 07:06:55
Also in:
netfilter-devel
Subsystem:
netfilter, networking [general], the rest · Maintainers:
Pablo Neira Ayuso, Florian Westphal, "David S. Miller", Eric Dumazet, Jakub Kicinski, Paolo Abeni, Linus Torvalds
From: Maciej Żenczykowski <redacted>
this makes fchown() affect '-m owner --uid-owner'
Cc: Lorenzo Colitti <redacted>
Fixes: 86741ec25462 ('net: core: Add a UID field to struct sock.')
Signed-off-by: Maciej Żenczykowski <redacted>
---
net/netfilter/xt_owner.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/netfilter/xt_owner.c b/net/netfilter/xt_owner.c
index e85ce69924ae..3eebd9c7ea4b 100644
--- a/net/netfilter/xt_owner.c
+++ b/net/netfilter/xt_owner.c@@ -84,8 +84,8 @@ owner_mt(const struct sk_buff *skb, struct xt_action_param *par) if (info->match & XT_OWNER_UID) { kuid_t uid_min = make_kuid(net->user_ns, info->uid_min); kuid_t uid_max = make_kuid(net->user_ns, info->uid_max); - if ((uid_gte(filp->f_cred->fsuid, uid_min) && - uid_lte(filp->f_cred->fsuid, uid_max)) ^ + if ((uid_gte(sk->sk_uid, uid_min) && + uid_lte(sk->sk_uid, uid_max)) ^ !(info->invert & XT_OWNER_UID)) return false; }
--
2.34.1.307.g9b7440fafd-goog