Re: [PATCH] sun4i-emac.c: add dma support
flat view
From: Jakub Kicinski <kuba@kernel.org>
Date: 2021-12-23 00:57:10
Also in:
linux-sunxi
On Wed, 22 Dec 2021 15:09:27 +0800 conleylee@foxmail.com wrote:
quoted hunk ↗ jump to hunk
-#define DRV_NAME "sun4i-emac" +#define DRV_NAME "sun4i-emac" -#define EMAC_MAX_FRAME_LEN 0x0600 +#define EMAC_MAX_FRAME_LEN 0x600 #define EMAC_DEFAULT_MSG_ENABLE 0x0000 -static int debug = -1; /* defaults above */; +static int debug = -1; /* defaults above */ +; module_param(debug, int, 0); MODULE_PARM_DESC(debug, "debug message flags");@@ -69,24 +71,25 @@ MODULE_PARM_DESC(watchdog, "transmit timeout in milliseconds"); */ struct emac_board_info { - struct clk *clk; - struct device *dev; - struct platform_device *pdev; - spinlock_t lock; - void __iomem *membase; - u32 msg_enable; - struct net_device *ndev; - struct sk_buff *skb_last; - u16 tx_fifo_stat; - - int emacrx_completed_flag; - - struct device_node *phy_node; - unsigned int link; - unsigned int speed; - unsigned int duplex; - - phy_interface_t phy_interface; + struct clk *clk; + struct device *dev; + struct platform_device *pdev; + spinlock_t lock; + void __iomem *membase; + u32 msg_enable; + struct net_device *ndev; + u16 tx_fifo_stat; + + int emacrx_completed_flag; + + struct device_node *phy_node; + unsigned int link; + unsigned int speed; + unsigned int duplex; + + phy_interface_t phy_interface; + struct dma_chan *rx_chan; + phys_addr_t emac_rx_fifo;
Please remove all the code formatting changes from the patch and repost. It makes it hard to review the patch when most of it is an unrelated whitespace modification.