Re: [PATCH net] veth: ensure skb entering GRO are not cloned.

On Wed, 2021-12-22 at 03:58 -0800, Eric Dumazet wrote:

On Wed, Dec 22, 2021 at 3:06 AM Paolo Abeni [off-list ref] wrote:

quoted

I thought about something similar, but I overlooked possible OoO or
behaviour changes when a packet socket is attached to the paired device
(as it would disable GRO).

Have you tried a pskb_expand_head() instead of a full copy ?
Perhaps that would be enough, and keep all packets going through GRO to
make sure OOO is covered.

Indeed it looks like it's enough. I'll do some more testing and I'll
send a v2 using pskb_expand_head().

Many thanks!

Paolo