Re: [PATCH net-next v2] mctp: emit RTM_NEWADDR and RTM_DELADDR

On Fri, 2021-12-17 at 11:42 -0800, Jakub Kicinski wrote:

	return NLMSG_ALIGN(sizeof(struct ifaddrmsg))

quoted

+		+ nla_total_size(4) // IFA_LOCAL
+		+ nla_total_size(4) // IFA_ADDRESS

why 4? The attributes are u8, no?

quoted

+	if (rc < 0)

How about a customary WARN_ON_ONCE(rc == -EMSGSIZE) here?

Thanks for the review Jakub. Size 4 is a mistake, I'll send v3.

Cheers,
Matt