Re: Issues with smsc95xx driver since a049a30fc27c

On 2021-12-18 20:32, Andrew Lunn wrote:

quoted

O.K, stab in the dark. Does the hardware need to be programmed with
the MAC address? When does this happen? If this is going wrong, it
could explain the promisc mode. If the MAC address has not been
programmed, it has no idea what packets are for itself. Put it into
promisc mode, and it will receive everything, including what it is
supposed to receive. But looking at the offending patch, it is not
obvious how it has anything to do with MAC addresses. The only
unbalanced change in that patch is that smsc95xx_reset(dev) has
disappeared, not moved to somewhere else.

Ah!

smsc95xx_reset() calls smsc95xx_set_mac_address(). So that fits.
smsc95xx_reset() is also called in smsc95xx_bind(), but maybe that is
not enough?

	Andrew

hi Andrew,

the odroid-u3 has no preconfigured mac address. the kernel from the vendor is patched to read a file in /etc and set the mac address read from it. with the mainline kernel the interface gets a random mac address that can later be changed by NetworkManager & Co. (as far as i know there's no "smsc95xx.macaddr=xx:xx:xx:xx:xx:xx" kernel boot parameter).

u-boot should be able to set the mac addreess, but it doesn't even detect the network interface and i get a message like "No NET interface" (even though i've tried the steps at https://github.com/ARM-software/u-boot/blob/master/doc/README.odroid).

Gabriel