Thread (3 messages) 3 messages, 2 authors, 2021-12-18

[PATCH net] bonding: fix ad_actor_system option setting to default

flat view
STALE1758d

From: Fernando Fernandez Mancera <hidden>
Date: 2021-12-17 18:29:17
Subsystem: bonding driver, networking drivers, the rest · Maintainers: Jay Vosburgh, Andrew Lunn, "David S. Miller", Eric Dumazet, Jakub Kicinski, Paolo Abeni, Linus Torvalds

When 802.3ad bond mode is configured the ad_actor_system option is set
to "00:00:00:00:00:00". But when trying to set the default value
manually it was failing with EINVAL.

A zero ethernet address is valid, only multicast addresses are not valid
values.

Signed-off-by: Fernando Fernandez Mancera <redacted>
---
 drivers/net/bonding/bond_options.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/bonding/bond_options.c b/drivers/net/bonding/bond_options.c
index a8fde3bc458f..b93337b5a721 100644
--- a/drivers/net/bonding/bond_options.c
+++ b/drivers/net/bonding/bond_options.c
@@ -1526,7 +1526,7 @@ static int bond_option_ad_actor_system_set(struct bonding *bond,
 		mac = (u8 *)&newval->value;
 	}
 
-	if (!is_valid_ether_addr(mac))
+	if (is_multicast_ether_addr(mac))
 		goto err;
 
 	netdev_dbg(bond->dev, "Setting ad_actor_system to %pM\n", mac);
-- 
2.30.2
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help