Thread (35 messages) 35 messages, 5 authors, 2022-01-13

Re: [PATCH net-next v3 05/12] net: wwan: t7xx: Add AT and MBIM WWAN ports

From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Date: 2021-12-16 13:00:19
Also in: linux-wireless

On Thu, Dec 16, 2021 at 02:25:47PM +0200, Ilpo Järvinen wrote:
On Mon, 6 Dec 2021, Ricardo Martinez wrote:
quoted
+		if (multi_packet == 1)
+			return actual_count;
+		else if (multi_packet == i + 1)
On top of that redundant 'else' here.
quoted
+			return count;
+	}
I'd recommend renaming variables to make it clearer what they count:
- count -> bytes
- actual_count -> actual_bytes
- multi_packet -> packets
-- 
With Best Regards,
Andy Shevchenko

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help