Thread (2 messages) 2 messages, 2 authors, 2021-12-16

Re: [PATCH v4] netdevsim: Zero-initialize memory for new map's value in function nsim_bpf_map_alloc

flat view

From: patchwork-bot+netdevbpf@kernel.org
Date: 2021-12-16 02:50:12

Hello:

This patch was applied to netdev/net.git (master)
by Jakub Kicinski [off-list ref]:

On Wed, 15 Dec 2021 19:15:30 +0800 you wrote:
Zero-initialize memory for new map's value in function nsim_bpf_map_alloc
since it may cause a potential kernel information leak issue, as follows:
1. nsim_bpf_map_alloc calls nsim_map_alloc_elem to allocate elements for
a new map.
2. nsim_map_alloc_elem uses kmalloc to allocate map's value, but doesn't
zero it.
3. A user application can use IOCTL BPF_MAP_LOOKUP_ELEM to get specific
element's information in the map.
4. The kernel function map_lookup_elem will call bpf_map_copy_value to get
the information allocated at step-2, then use copy_to_user to copy to the
user buffer.
This can only leak information for an array map.

[...]
Here is the summary with links:
  - [v4] netdevsim: Zero-initialize memory for new map's value in function nsim_bpf_map_alloc
    https://git.kernel.org/netdev/net/c/481221775d53

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help