Re: [PATCH net-next 1/7] net: phylink: add mac_select_pcs() method to phylink_mac_ops
flat view
From: Jakub Kicinski <kuba@kernel.org>
Date: 2021-12-15 02:35:12
On Tue, 14 Dec 2021 14:48:05 +0000 Russell King (Oracle) wrote:
+/** + * @mac_select_pcs: Select a PCS for the interface mode.
nit: no '@' in front of the function name
quoted hunk ↗ jump to hunk
+ * @config: a pointer to a &struct phylink_config. + * @interface: PHY interface mode for PCS + * + * Return the &struct phylink_pcs for the specified interface mode, or + * NULL if none is required, or an error pointer on error. + * + * This must not modify any state. It is used to query which PCS should + * be used. Phylink will use this during validation to ensure that the + * configuration is valid, and when setting a configuration to internally + * set the PCS that will be used. + */ +struct phylink_pcs *mac_select_pcs(struct phylink_config *config, + phy_interface_t interface);