Re: [PATCH net] net: dsa: hellcreek: Allow PTP on blocked ports

Hi Richard,

On Mon Dec 13 2021, Richard Cochran wrote:

On Mon, Dec 13, 2021 at 11:18:10AM +0100, Kurt Kanzenbach wrote:

quoted

@@ -1055,7 +1058,7 @@ static int hellcreek_setup_fdb(struct hellcreek *hellcreek)
 		.portmask     = 0x03,	/* Management ports */
 		.age	      = 0,
 		.is_obt	      = 0,
-		.pass_blocked = 0,
+		.pass_blocked = 1,

This one should stay blocked.

You're right. I confirmed with Hirschmann. Only peer delay measurements
should be allowed on blocked ports. In addition, we also have to add
static entries for STP with pass_blocked bit set. Furthermore, the UDP
entries are missing as well. Currently it only works for 802.1AS even
though the driver happily announces V2_EVENT capability.

I'll clean it up and resend properly.

Thanks,
Kurt