Re: [PATCH net] sch_cake: do not call cake_destroy() from cake_init()

Eric Dumazet [off-list ref] writes:

On Fri, Dec 10, 2021 at 3:02 AM Toke Høiland-Jørgensen [off-list ref] wrote:

quoted

Eric Dumazet [off-list ref] writes:

quoted

From: Eric Dumazet <redacted>

qdiscs are not supposed to call their own destroy() method
from init(), because core stack already does that.

syzbot was able to trigger use after free:

quoted

quoted

Fixes: 046f6fd5daef ("sched: Add Common Applications Kept Enhanced (cake) qdisc")
Signed-off-by: Eric Dumazet <redacted>
Reported-by: syzbot <redacted>
Signed-off-by: Toke Høiland-Jørgensen <toke@toke.dk>

Oops, thanks for the fix! I'm a little puzzled with the patch has my
S-o-b, though? It should probably be replaced by:

Acked-by: Toke Høiland-Jørgensen <toke@toke.dk>

Right, user error from my side, I copied it from your commit changelog
and forgot to s/Signed-off-by/Cc/

Ah, right, makes sense; no worries :)

-Toke