Re: [RFC PATCH net-next 2/2] net: Reset forwarded skb->tstamp before delivering to user space

From
Eric Dumazet <hidden>
Date
2021-12-10 10:19:31
Reply to
Martin KaFai Lau, 2021-12-08
On Wed, Dec 8, 2021 at 12:48 PM Martin KaFai Lau [off-list ref] wrote:
On Wed, Dec 08, 2021 at 10:27:51AM -0800, Eric Dumazet wrote:
quoted
On Wed, Dec 8, 2021 at 12:30 AM Martin KaFai Lau [off-list ref] wrote:
quoted
For non bpf ingress, hmmm.... yeah, not sure if it is indeed an issue :/
may be save the tx tstamp first and then temporarily restamp with __net_timestamp()
Martin, have you looked at time namespaces (CLONE_NEWTIME) ?

Perhaps we need to have more than one bit to describe time bases.
My noob understanding is it only affects the time returning
to the user in the syscall.  Could you explain how that
may affect the time in skb->tstamp?
I would think it should affect timestamps (rx/tx network ones),
otherwise user applications would be broken ?
Thread (18 messages) 18 messages, 4 authors, last reply 2021-12-10
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help