Re: [PATCHv2 net-next 1/2] net_tstamp: add new flag HWTSTAMP_FLAG_BONDED_PHC_INDEX
flat view
From: Richard Cochran <richardcochran@gmail.com>
Date: 2021-12-09 21:33:52
On Thu, Dec 09, 2021 at 06:24:48PM +0800, Hangbin Liu wrote:
quoted hunk ↗ jump to hunk
+/* possible values for hwtstamp_config->flags */ +enum hwtstamp_flags { + /* + * With this flag, the user could get bond active interface's + * PHC index. Note this PHC index is not stable as when there + * is a failover, the bond active interface will be changed, so + * will be the PHC index. + */ + HWTSTAMP_FLAG_BONDED_PHC_INDEX = (1<<0), + + /* add new constants above here */ + __HWTSTAMP_FLAGS_CNT +};
I think this shouldn't be an enumerated type, but rather simply a bit field of independent options. Thanks, Richard