Re: [PATCH] net: dsa: mv88e6xxx: fix uninit-value err in mv88e6393x_serdes_power

On Mon, 6 Dec 2021 14:45:11 +0100
Andrew Lunn [off-list ref] wrote:

On Mon, Dec 06, 2021 at 06:13:52PM +0800, Jackie Liu wrote:

quoted

From: Jackie Liu <redacted>

'err' is not initialized. If the value of cmode is not in the switch case,
it will cause a logic error and return early.  

Same fix as: [ref]

At least here some analysis has been done why there is a warning.

Should we add a default?

       Andrew

indeed it should be err=0