Re: [PATCH net] devlink: fix netns refcount leak in devlink_nl_cmd_reload()

On Sun, Dec 05, 2021 at 11:28:22AM -0800, Eric Dumazet wrote:

From: Eric Dumazet <redacted>

While preparing my patch series adding netns refcount tracking,
I spotted bugs in devlink_nl_cmd_reload()

Some error paths forgot to release a refcount on a netns.

To fix this, we can reduce the scope of get_net()/put_net()
section around the call to devlink_reload().

Fixes: ccdf07219da6 ("devlink: Add reload action option to devlink reload command")
Fixes: dc64cc7c6310 ("devlink: Add devlink reload limit option")
Signed-off-by: Eric Dumazet <redacted>
Cc: Moshe Shemesh <redacted>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: Jacob Keller <jacob.e.keller@intel.com>
Cc: Jiri Pirko <redacted>
---
 net/core/devlink.c | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

Thanks,
Reviewed-by: Leon Romanovsky <leonro@nvidia.com>