Re: [PATCH net-next 2/7] net: wwan: iosm: set tx queue len

On Sun, Dec 5, 2021 at 4:52 PM Kumar, M Chetan
[off-list ref] wrote:

On 12/5/2021 4:46 PM, Sergey Ryazanov wrote:

quoted

On Sun, Dec 5, 2021 at 9:47 AM M Chetan Kumar
[off-list ref] wrote:

quoted

Set wwan net dev tx queue len to 1000.

Signed-off-by: M Chetan Kumar <redacted>
---
  drivers/net/wwan/iosm/iosm_ipc_wwan.c | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/net/wwan/iosm/iosm_ipc_wwan.c b/drivers/net/wwan/iosm/iosm_ipc_wwan.c
index b571d9cedba4..e3fb926d2248 100644
--- a/drivers/net/wwan/iosm/iosm_ipc_wwan.c
+++ b/drivers/net/wwan/iosm/iosm_ipc_wwan.c

@@ -18,6 +18,7 @@
  #define IOSM_IP_TYPE_IPV6 0x60

  #define IOSM_IF_ID_PAYLOAD 2
+#define IOSM_QDISC_QUEUE_LEN 1000

Is this 1000 something special for the IOSM driver? If you need just
an approximate value for the queue length, then consider using the
common DEFAULT_TX_QUEUE_LEN macro, please.
We had set an approximate value for the queue length.

Sure, will use the common queue length macro (DEFAULT_TX_QUEUE_LEN)
instead of defining the new macro.

Thank you! The series looks good to me, so feel free to add my:

Reviewed-by: Sergey Ryazanov <ryazanov.s.a@gmail.com>