Re: [PATCH v2 net-next 02/23] lib: add tests for reference tracker

On Sat, Dec 4, 2021 at 4:45 PM Eric Dumazet [off-list ref] wrote:

On Sat, Dec 4, 2021 at 3:40 PM kernel test robot [off-list ref] wrote:

quoted

Hi Eric,

I love your patch! Yet something to improve:

[auto build test ERROR on net-next/master]

url:    https://github.com/0day-ci/linux/commits/Eric-Dumazet/net-add-preliminary-netdev-refcount-tracking/20211203-104930
base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git fc993be36f9ea7fc286d84d8471a1a20e871aad4
config: nios2-allyesconfig (https://download.01.org/0day-ci/archive/20211205/202112050729.hISLa0oF-lkp@intel.com/config)
compiler: nios2-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/98ad7e89138f4176a549203b6e23c2dc1cb9581d
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Eric-Dumazet/net-add-preliminary-netdev-refcount-tracking/20211203-104930
        git checkout 98ad7e89138f4176a549203b6e23c2dc1cb9581d
        # save the config file to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=nios2 SHELL=/bin/bash

I tried following these instructions, but this failed on my laptop.

quoted

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <redacted>

All errors (new ones prefixed by >>):

   lib/ref_tracker.c: In function 'ref_tracker_alloc':

quoted

quoted

lib/ref_tracker.c:80:22: error: implicit declaration of function 'stack_trace_save'; did you mean 'stack_depot_save'? [-Werror=implicit-function-declaration]

      80 |         nr_entries = stack_trace_save(entries, ARRAY_SIZE(entries), 1);
         |                      ^~~~~~~~~~~~~~~~
         |                      stack_depot_save

quoted

quoted

lib/ref_tracker.c:81:22: error: implicit declaration of function 'filter_irq_stacks' [-Werror=implicit-function-declaration]

      81 |         nr_entries = filter_irq_stacks(entries, nr_entries);
         |                      ^~~~~~~~~~~~~~~~~
   cc1: some warnings being treated as errors

Kconfig warnings: (for reference only)
   WARNING: unmet direct dependencies detected for REF_TRACKER
   Depends on STACKTRACE_SUPPORT
   Selected by
   - TEST_REF_TRACKER && RUNTIME_TESTING_MENU && DEBUG_KERNEL

This seems to be a bug unrelated to this patch series.

Ah... maybe I got the Kconfig thing wrong.

This is hard to believe we will have to duplicate " depends on
STACKTRACE_SUPPORT" for all trackers
will intend to have (I have a series for netns refcount tracking)

diff --git a/net/Kconfig b/net/Kconfig
index 0b665e60b53490f44eeda1e5506d4e125ef4c53a..b54e233b8dd38ea153ac3500df1e8a2557097ba6

100644

--- a/net/Kconfig
+++ b/net/Kconfig

@@ -255,6 +255,7 @@ config PCPU_DEV_REFCNT

 config NET_DEV_REFCNT_TRACKER
        bool "Enable tracking in dev_put_track() and dev_hold_track()"
+       depends on STACKTRACE_SUPPORT
        select REF_TRACKER
        default n
        help

I thought that having the dependency centralized in REF_TRACKER would
be enough really ?

config REF_TRACKER
        bool
        depends on STACKTRACE_SUPPORT
        select STACKDEPOT