RE: [PATCH net-next 2/2] net: optimize skb_postpull_rcsum()

...

quoted

There are also 40 csum_partial(buf, len, 0).
If all the buffer is zero they'll return zero - invalid.
They ought to be changed to csum_partial(buf, len, 0xffff).

Please point where all zero buffers can be valid in the first place.

They probably can't be.
But I bet a lot of the code was written without realising it mattered.

A quick scan does imply that they are all probably ok.

But I have spotted 18 ~csum_fold() - they may be dubious.

	David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)