RE: [EXT] Re: [PATCH net] qede: validate non LSO skb length

-----Original Message-----
From: Jakub Kicinski <kuba@kernel.org>
Sent: Thursday, November 25, 2021 5:08 AM
To: Manish Chopra <manishc@marvell.com>
Cc: netdev@vger.kernel.org; Ariel Elior <redacted>; Alok Prasad
[off-list ref]; Prabhakar Kushwaha [off-list ref]
Subject: [EXT] Re: [PATCH net] qede: validate non LSO skb length

External Email

----------------------------------------------------------------------
On Wed, 24 Nov 2021 01:24:05 -0800 Manish Chopra wrote:

quoted

Although it is unlikely that stack could transmit a non LSO skb with
length > MTU, however in some cases or environment such occurrences
actually resulted into firmware asserts due to packet length being
greater than the max supported by the device (~9700B).

This patch adds the safeguard for such odd cases to avoid firmware
asserts.

Signed-off-by: Manish Chopra <manishc@marvell.com>
Signed-off-by: Alok Prasad <redacted>
Signed-off-by: Prabhakar Kushwaha <redacted>
Signed-off-by: Ariel Elior <redacted>

Please add an appropriate Fixes tag and repost.

Hello Jakub,

I don't really know which commit has introduced this exactly. It was probably day1 (when this driver was submitted) behavior,
just that this issue was discovered recently by some customer environment.
Let me know if you want me to put one of those initial driver commit tag here and repost ? 

Thanks,
Manish