Thread (4 messages) 4 messages, 4 authors, 2021-12-02

How to avoid getting ndo_open() immediately after probe

flat view

From: Arijit De <hidden>
Date: 2021-12-02 18:11:46

Hi,

I have handled the probe() and registered the netdev structure using register_netdev().
I have observed in other opensource driver(i.e. Intel e1000e driver) that ndo_open() gets called only when we try to bring up the interface (i.e. ifconfig <ip> ifconfig eth0 <ip-addr> netmask <net-mask> up).
But in my network driver I am getting ndo_open() call immediately after I handle the probe(). It's a wrong behavior, also my network interface is getting to UP/RUNNING state(as shown below) even without any valid ip address.

enp1s0: flags=4163<UP,BROADCAST,RUNNING,MULTICAST>  mtu 1500
        ether 00:22:55:33:22:28  txqueuelen 1000  (Ethernet)
        RX packets 0  bytes 0 (0.0 B)
        RX errors 0  dropped 0  overruns 0  frame 0
        TX packets 252  bytes 43066 (43.0 KB)
        TX errors 0  dropped 0 overruns 0  carrier 0  collisions

What is the change required in the driver such that my network interface(enp1s0) should be in down state(BROADCAST & MULTICAST only) after probe()
and ndo_open() call should happen only when device gets configured?

Thanks
Arijit
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help