Thread (11 messages) 11 messages, 3 authors, 2021-11-18

Re: [RFC PATCH 1/2] bpf: do not WARN in bpf_warn_invalid_xdp_action()

flat view

From: Toke Høiland-Jørgensen <hidden>
Date: 2021-11-15 16:21:50
Also in: bpf

Paolo Abeni [off-list ref] writes:
The WARN_ONCE() in bpf_warn_invalid_xdp_action() can be triggered by
any bugged program, and even attaching a correct program to a NIC
not supporting the given action.

The resulting splat, beyond polluting the logs, fouls automated tools:
e.g. a syzkaller reproducers using an XDP program returning an
unsupported action will never pass validation.

Replace the WARN_ONCE with a less intrusive pr_warn_once().

Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Acked-by: Toke Høiland-Jørgensen <redacted>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help