Re: [PATCH v2 bpf-next 2/3] bpf: Fix propagation of signed bounds from 64-bit min/max into 32-bit.
From: Yonghong Song <hidden>
Date: 2021-11-01 23:12:15
Also in:
bpf
On 11/1/21 4:06 PM, Alexei Starovoitov wrote:
On Mon, Nov 1, 2021 at 4:03 PM Yonghong Song [off-list ref] wrote:quoted
On 11/1/21 3:21 PM, Alexei Starovoitov wrote:quoted
From: Alexei Starovoitov <ast@kernel.org> Similar to unsigned bounds propagation fix signed bounds. The 'Fixes' tag is a hint. There is no security bug here. The verifier was too conservative. Fixes: 3f50f132d840 ("bpf: Verifier, do explicit ALU32 bounds tracking") Signed-off-by: Alexei Starovoitov <ast@kernel.org>The change looks good. Should a new test_verifier test be added to exercise the new change?I think manually string comparing output the way VERBOSE_ACCEPT is doing is an overkill here. The real test case in .c will take some time to craft.
Okay. Sounds good to me. Acked-by: Yonghong Song <redacted>