Re: [PATCH] libbpf: remove unneeded conversion to bool
From: Daniel Borkmann <daniel@iogearbox.net>
Date: 2021-11-25 23:15:07
Also in:
bpf, lkml
On 11/25/21 1:54 AM, davidcomponentone@gmail.com wrote:
From: Yang Guang <redacted> The coccinelle report ./tools/lib/bpf/libbpf.c:1644:43-48: WARNING: conversion to bool not needed here Relational and logical operators evaluate to bool, explicit conversion is overly verbose and unneeded. Reported-by: Zeal Robot <redacted> Signed-off-by: Yang Guang <redacted>
Nak, dup of: https://lore.kernel.org/bpf/CAEf4BzaADXguVoh0KXxGYhzG68eA1bqfKH1T1SWyPvkE5BHa5g@mail.gmail.com/ (local)
quoted hunk ↗ jump to hunk
--- tools/lib/bpf/libbpf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/tools/lib/bpf/libbpf.c b/tools/lib/bpf/libbpf.c index 14a89dc99937..33eb365a0b7f 100644 --- a/tools/lib/bpf/libbpf.c +++ b/tools/lib/bpf/libbpf.c@@ -1641,7 +1641,7 @@ static int set_kcfg_value_tri(struct extern_desc *ext, void *ext_val, ext->name, value); return -EINVAL; } - *(bool *)ext_val = value == 'y' ? true : false; + *(bool *)ext_val = value == 'y'; break; case KCFG_TRISTATE: if (value == 'y')