Thread (4 messages) flat view 4 messages, 3 authors, 2021-11-22

Re: [PATCH] net-sysfs: Slightly optimize 'xps_queue_show()'

From: Xin Long <lucien.xin@gmail.com>
Date: 2021-11-22 15:23:21
Also in: kernel-janitors, lkml

On Sun, Nov 21, 2021 at 2:38 PM Christophe JAILLET
[off-list ref] wrote:
quoted hunk ↗ jump to hunk
The 'mask' bitmap is local to this function. So the non-atomic
'__set_bit()' can be used to save a few cycles.

Signed-off-by: Christophe JAILLET <redacted>
---
 net/core/net-sysfs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/core/net-sysfs.c b/net/core/net-sysfs.c
index 9c01c642cf9e..3be3f4a6add3 100644
--- a/net/core/net-sysfs.c
+++ b/net/core/net-sysfs.c
@@ -1452,7 +1452,7 @@ static ssize_t xps_queue_show(struct net_device *dev, unsigned int index,

                for (i = map->len; i--;) {
                        if (map->queues[i] == index) {
-                               set_bit(j, mask);
+                               __set_bit(j, mask);
                                break;
                        }
                }
--
2.30.2
The similar optimization can seem to be done in br_vlan.c and br_if.c as well.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help