Re: [net-next PATCH 18/19] net: dsa: qca8k: use device_get_match_data instead of the OF variant
From: Vladimir Oltean <olteanv@gmail.com>
Date: 2021-11-21 18:04:05
Also in:
lkml
On Fri, Nov 19, 2021 at 03:32:06AM +0100, Ansuel Smith wrote:
On Fri, Nov 19, 2021 at 04:21:36AM +0200, Vladimir Oltean wrote:quoted
On Wed, Nov 17, 2021 at 10:04:50PM +0100, Ansuel Smith wrote:quoted
Drop of_platform include and device_get_match_data instead of the OF variant. Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com> ---Why? Any ACPI device coming?No ACPI device coming. Notice we could drop an extra include. Is using device API wrong for OF only drivers? Just asking will drop if it can cause any problem or confusion.
No problem, just that this patch is a bit weak on the justification side. People usually don't make changes just for the fun of it.